[
http://issues.apache.org/jira/browse/DERBY-147?page=comments#action_12422745 ]
Bernd Ruehlicke commented on DERBY-147:
---------------------------------------
Simple question:
Is most of the source checked in from Linux /Unix ? It seems to me when I
checout the code it gets reformatted.
Here how part of the code of
./engine/org/apache/derby/impl/sql/compile/ResultColumnList.java looks like
just after checkout (not touched by my IDE yet)
Any special standart who files are suppose to be checked in ? Aka Windows Ascii
format or Unix ?
/**
* For order by, get a ResultColumn that matches the specified
* columnName and ensure that there is only one match before the bind
process.
*
* @param columnName The ResultColumn to get from the list
* @param tableName The table name on the OrderByColumn, if any
*
* @return the column that matches that name.
* @exception StandardException thrown on duplicate
*/
public ResultColumn getOrderByColumn(String columnName, TableName
tableName)
throws StandardException
{
int size = size();
ResultColumn retVal = null, resultColumn;
for (int index = 0; index < size; index++)
{
resultColumn = (ResultColumn) elementAt(index);
// We may be checking on "ORDER BY T.A" against "SELECT
*".
// exposedName will not be null and "*" will not have
an expression
// or tablename.
// We may be checking on "ORDER BY T.A" against "SELECT
T.B, T.A".
if (tableName != null)
{
ValueNode rcExpr = resultColumn.getExpression();
if (rcExpr == null || ! (rcExpr instanceof
ColumnReference))
{
continue;
}
ColumnReference cr = (ColumnReference) rcExpr;
if( ! tableName.equals( cr.getTableNameNode()))
continue;
}
/* We finally got past the qualifiers, now see if the
column
* names are equal.
*/
> ERROR 42X79 not consistant ? - same column name specified twice
> ---------------------------------------------------------------
>
> Key: DERBY-147
> URL: http://issues.apache.org/jira/browse/DERBY-147
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Reporter: Bernd Ruehlicke
> Attachments: derby-147-10.0.2.1.diff, derby-147.diff
>
>
> This happens from JDBC or ij. Here the output form ij>
> ij version 10.0
> CONNECTION0* - jdbc:derby:phsDB
> * = current connection
> ij> select a1.XXX_foreign, a1.native, a1.kind, a1.XXX_foreign FROM
> slg_name_lookup a1 ORDER BY a1.XXX_foreign;
> ERROR 42X79: Column name 'XXX_FOREIGN' appears more than once in the result
> of the query expression.
> But when removing the ORDER BY and keeping the 2 same column names it works
> ij> select a1.XXX_foreign, a1.native, a1.kind, a1.XXX_foreign FROM
> slg_name_lookup a1;
> XXX_FOREIGN
> |NATIVE
> |KIND |XXX_FOREIGN
>
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> 0 rows selected
> ij>
> So - it seams to be OK to specify the same column twice - as long as you do
> not add the ORDER BY clause.
> I woul dof course like that the system allows this - but at leats it should
> be consistant and either allow both or none of the two queries above.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
