I haven't had a chance to test these, but I would love to see these go
into the bin distribution.
I think a README in the frameworks directory is a good thing to do, as
well as a release note, as well as updating the docs. No harm in saying
it multiple times in multiple ways. We should also add the new scripts
to the interfaces table at
http://wiki.apache.org/db-derby/ForwardCompatibility
and modify the old scripts to have a classification as "Deprecated".
David
Andrew McIntyre (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1032?page=comments#action_12427135 ]
Andrew McIntyre commented on DERBY-1032:
----------------------------------------
I would love to hear some feedback on the latest patch for this. Do we want to
deprecate the frameworks scripts and go with these new scripts in a top-level
bin directory for the -bin distribution (and probably also the snapshots)?
I'm tempted to commit the patch as-is, simply adding the new scripts in the bin
directory so that others can review/collaborate on the new scripts whether we
decide to go with these for 10.2 or not. I admit, I haven't had the time to
test these as extensively as I would have liked in different environments. But,
a few months ago there was consensus that what we have now in the frameworks
directory should eventually go away and be replaced by new scripts which
follows the conventions set by other Apache projects and which are more
portable to different shell environments.
A complete fix would add these new scripts to the -bin distribution and
snapshots, but due to the lack of feedback, I'm not sure that's the right way
to go. Please comment if you feel these are worthwhile and should replace what
we have in the frameworks directory.
If we do decide to include these scripts, then we also need to have a
discussion about how we plan to mark the framework scripts as deprecated
(release note? readme in the frameworks directory? something else? all of the
above?). Considering where we are with the schedule currently proposed by our
release manager for 10.2, there's not a lot of time for that discussion, so if
you have an opinion, please speak up!
Create new scripts which follow common practice at Apache
---------------------------------------------------------
Key: DERBY-1032
URL: http://issues.apache.org/jira/browse/DERBY-1032
Project: Derby
Issue Type: Improvement
Components: Demos/Scripts
Affects Versions: 10.2.0.0
Reporter: Andrew McIntyre
Assigned To: Andrew McIntyre
Priority: Minor
Fix For: 10.2.0.0
Attachments: derby-1032-bin-sh.tgz, derby-1032-v1.diff,
derby-1032-v2.diff
Scripts for Derby should be written to follow common practice at Apache. This
means locating them in a bin directory, and self configuring from the minimum
amount of information necessary: installation location and in our case, the
location of Java, from the variables DERBY_HOME and JAVA_HOME respectively. If
these variables are not set, we should report this to the user. Good examples
are available in Ant, Forrest, and Maven, and much of the same setup code can
be reused from those projects.
