[ http://issues.apache.org/jira/browse/DERBY-1130?page=all ]
Deepa Remesh resolved DERBY-1130.
---------------------------------
Resolution: Fixed
Derby Info: [Patch Available, Existing Application Impact, Release Note
Needed] (was: [Release Note Needed, Patch Available, Existing Application
Impact])
Verified the fix is in trunk (10.3) and 10.2 branch.
Here is the release note for this issue:
PROBLEM:
Derby's client DataSources were using a wrong database name when getting a
connection in the following case:
* databaseName is not set as a Derby DataSource property
* databaseName is set as a connection attribute using setConnectionAttributes
method
SYMPTOM:
Instead of throwing an exception saying databaseName is a required Derby
DataSource property and must be set, client driver was using "null" as database
name and returning a connection to database named "null".
CAUSE:
The database name was constructed wrongly in the client driver.
SOLUTION:
This was solved by setting the internal database name property in the client
driver correctly. Also ensured that databaseName set as a connection attribute
will not be used by Derby's client DataSources.. This fix will be available in
Derby versions 10.2 and above.
WORKAROUND:
If using release prior to version 10.2, make sure database name is set only as
a DataSource property when using Derby's client DataSources.
> Client should not allow databaseName to be set with setConnectionAttributes
> ---------------------------------------------------------------------------
>
> Key: DERBY-1130
> URL: http://issues.apache.org/jira/browse/DERBY-1130
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1,
> 10.1.2.2, 10.1.2.3, 10.2.1.0, 10.1.3.0, 10.1.2.4
> Reporter: Kathey Marsden
> Assigned To: Deepa Remesh
> Fix For: 10.2.1.0, 10.3.0.0
>
> Attachments: d1130-client-v1.diff, d1130-client-v1.status,
> d1130-test-dataSourceReference.diff, d1130-test-dataSourceReference.status,
> d1130-v2.diff, d1130-v2.status, derby-1130-v1.diff, derby-1130-v1.status
>
>
> Per this thread, setConnectionAttributes should not set databaseName.
> http://www.nabble.com/double-check-on-checkDataSource-t1187602.html#a3128621
> Currently this is allowed for client but should be disabled. I think it is
> OK to change because we have documented that client will be changed to match
> embedded for implementation defined behaviour. Hopefully its use is rare as
> most folks would use the standard setDatabaseName. Still there should be a
> release not when the change is made and it would be better to change it
> sooner than later:
> Below is the repro.
> Here is the output with Client
> D>java DatabaseNameWithSetConnAttr
> ds.setConnectionAttributes(databaseName=wombat;create=true)
> ds.getDatabaseName() = null (should be null)
> FAIL: Should not have been able to set databaseName with connection attributes
> Also look for tests disabled with this bug number in the test
> checkDataSource30.java
> import java.sql.*;
> import java.lang.reflect.Method;
> public class DatabaseNameWithSetConnAttr{
> public static void main(String[] args) {
> try {
>
> String attributes = "databaseName=wombat;create=true";
> org.apache.derby.jdbc.ClientDataSource ds = new
> org.apache.derby.jdbc.ClientDataSource();
> //org.apache.derby.jdbc.EmbeddedDataSource ds = new
> //org.apache.derby.jdbc.EmbeddedDataSource();
> System.out.println("ds.setConnectionAttributes(" +
> attributes + ")");
> ds.setConnectionAttributes(attributes);
> System.out.println("ds.getDatabaseName() = " +
> ds.getDatabaseName()
> + " (should be null)" );
> Connection conn = ds.getConnection();
> } catch (SQLException e) {
> String sqlState = e.getSQLState();
> if (sqlState != null &&
> sqlState.equals("XJ041"))
> {
> System.out.println("PASS: An exception was
> thrown trying to get a connetion from a datasource after setting databaseName
> with setConnectionAttributes");
> System.out.println("EXPECTED EXCEPTION: " +
> e.getSQLState()
> + "
> - " + e.getMessage());
> return;
> }
> while (e != null)
> {
> System.out.println("FAIL - UNEXPECTED
> EXCEPTION: " + e.getSQLState());
> e.printStackTrace();
> e = e.getNextException();
> }
> return;
> }
> System.out.println("FAIL: Should not have been able to set
> databaseName with connection attributes");
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
