[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12433196 ] Knut Anders Hatlen commented on DERBY-1610: -------------------------------------------
Hi Tomohito, Thank you for working on this issue! I have only had a brief look at your patch. It looks like a great start, but I have a couple of questions/comments: 1) throwLangDataTypeSetException() throws an exception with state XCL12. Does that match embedded? I though embedded used 22005. 2) Would it be possible to have the integer arrays as constants? I think it would be good to avoid allocating a new array for each call to a setter method. Also, it would make the getPossibleTypesForNull() method more compact. 3) checkType() uses Arrays.binarySearch(), which requires that the array is sorted, but I don't think the arrays that are passed in are sorted. > Resolve difference of type compatibility between Embedded and > NetworkServer/NetworkDriver > ----------------------------------------------------------------------------------------- > > Key: DERBY-1610 > URL: http://issues.apache.org/jira/browse/DERBY-1610 > Project: Derby > Issue Type: Bug > Components: Network Server, Network Client > Reporter: Tomohito Nakayama > Assigned To: Tomohito Nakayama > Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, > parameterMapping.diff, parameterMapping.diff, > parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, > parameterMapping_3.diff, TestNullChar.java > > > There exists difference of type compatibility between Embedded and > NetworkServer/NetworkClient. > This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
