[ 
http://issues.apache.org/jira/browse/DERBY-1490?page=comments#action_12445349 ] 
            
Yip Ng commented on DERBY-1490:
-------------------------------

Hi Bryan, thanks for working on this feature!

I am having trouble applying the patch cleanly with the current trunk (rev# 
468656) though.  I think its 
probably due to some recent check-in with master outputs that conflicts with 
the current patch.  I did 
however reviewed the diff files and they look reasonable to me.  Some comments 
regarding your questions:

1)  IMHO, since Derby already have support for RENAME TABLE and RENAME INDEX 
statement, 
    I think RENAME COLUMN would be a natural fit for this feature than the 
other form.
    
2)  The patch's test coverage is good and I think adding testcases with synonym 
would be a nice addition.  

3) and 4)  I am ok with the behavior you described.

Since the lang/alterTable.sql is already setup to run in SQL authorization 
mode, I was wondering if it can also be run in legacy mode(non-SQL 
authorization) as well?  (Perhaps another jira entry should address this issue 
since it applies to other lang tests in general.)

 

> Provide ALTER TABLE RENAME COLUMN functionality
> -----------------------------------------------
>
>                 Key: DERBY-1490
>                 URL: http://issues.apache.org/jira/browse/DERBY-1490
>             Project: Derby
>          Issue Type: New Feature
>          Components: Documentation, SQL
>    Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.6, 10.1.2.1, 
> 10.1.3.1
>            Reporter: Bryan Pendleton
>         Assigned To: Bryan Pendleton
>         Attachments: 1490_cannot_patch.jpg, derby1490_v1_needMoreTests.diff, 
> renameColumn_v2_with_tests.diff
>
>
> Provide a way to rename a column in an existing table. Possible syntax could 
> be:
>   ALTER TABLE tablename RENAME COLUMN oldcolumn TO newcolumn;
> Feature should properly handle the possibility that the column is currently 
> used in constraints, views, indexes, triggers, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to