[ http://issues.apache.org/jira/browse/DERBY-1758?page=comments#action_12451843 ] Daniel John Debrunner commented on DERBY-1758: ----------------------------------------------
I think having the XML test/suite running even without a security manager is a good step forward. As long as there is some issue in Jira (could be this one) that remains open until the security manager is enabled for the test then it's fine. "Progress, not perfection" in the open source world. You can use the SecurityManagerSetup.noSecurityManager() decorator method to disable the Securitymanager and it can be applied on a fixture by fixture basis, see DatabaseClassLoadingTest for an example, or it could be for a whole suite. > Enable xmlSuite to run as part of derbyall for JVMs that embed the required > external jars. > ------------------------------------------------------------------------------------------ > > Key: DERBY-1758 > URL: http://issues.apache.org/jira/browse/DERBY-1758 > Project: Derby > Issue Type: Task > Components: Test > Affects Versions: 10.2.1.6, 10.3.0.0, 10.2.2.0 > Reporter: A B > Assigned To: A B > Attachments: d1758_followup_v1.patch, d1758_newJUnitTests_v1.patch, > d1758_newJUnitTests_v1.stat, d1758_newJUnitTests_v2.patch, > d1758_newSecMgr_doNotCommit.patch, d1758_newXBindTest_v1.patch, > d1758_remove_xgen_v1.patch, d1758_remove_xgen_v1.stat > > > Due to the fact the XML support in Derby has external dependencies on Apache > Xalan and a JAXP parser (such as, but not limited to, Apache Xerces), the > tests for XML, which are all included in "xmlSuite", are not currently run as > part of derbyall. > Changes for DERBY-688 (and DERBY-567 indirectly) have now made it so that > JVMs which have Apache Xalan and a JAXP parser embedded in them can run the > XML tests without requiring additional jars, assuming that the embedded > version of Xalan is at least the minimum version required by Derby (which is > currently 2.5). > So given that, the xmlSuite should be enabled as part of derbyall for any > JVMs that are capable of running them. Currently, this appears to mean only > ibm142 and ibm15. > Per comments in DERBY-688, enabling the XML suite could include the following > tasks: > 1. Enable the suite to run as part of derbyall but ONLY for JVMs that > embed the required Xalan/JAXP classes. > 2. Resolve the following diff in lang/xmlBinding.java that occurs on > some platforms (ex. Linux): > < Inserted roughly 40k of data. > 10 del > < Inserted roughly 40k of data. > 10a9,10 > > Inserted roughly 39k of data. > > Inserted roughly 37k of data. > 21 del > < 1, [ roughly 40k ] > 22 del > < 2, [ roughly 40k ] > 22a21,22 > > 1, [ roughly 39k ] > > 2, [ roughly 37k ] > 3. Add new tests to verify Derby behavior when XML classes are > not present. > Note that #3 may turn out to be its own Jira issue; the first two, however, > should both be addressed as part of this issue since the xmlSuite will not > run (and pass) on all platforms if either 1 or 2 is not addressed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
