[
https://issues.apache.org/jira/browse/DERBY-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466137
]
Daniel John Debrunner commented on DERBY-2087:
----------------------------------------------
I think the patch is generally fine but some of the comments in the
TestConfiguration methods confuse me and I'm not sure exactly what the model is
you are following. By model I mean how databases are handled, is there stil
only a single default database or does the configuration now handle & track
multple databases. I think the latter is the case but I'm not sure.
singleUseDatabaseDecorator(Test test, String dbName)
Its javadoc is copied from 'singleUseDatabaseDecorator(Test test)' but I don't
think it's doing the same thing. The original method is setting the default
database to a new single use database. I think the method being added is making
a new single use database available but is not making it the default. However
this is not clear from the javadoc. If the new method is making the new
database the default then I'm not sure of the benefit over the old one.
How does this database name relate to the singleUse folder?
Diff (from TestConfiguration)
* Obtain a new configuration identical to the passed in
- * one except for the database name.
+ * one except for the database name (change/removal).
The words '(change/removal)' have been added but I don't understand what they
are meant to imply in this context.
> Clean up of a database server directory after running junit tests.
> ------------------------------------------------------------------
>
> Key: DERBY-2087
> URL: https://issues.apache.org/jira/browse/DERBY-2087
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: d2087.diff, d2087.stat
>
>
> If I create a test using multiple connections using code like this
> DataSource ds1 = JDBCDataSource.getDataSource("FIRSTDB1");
> JDBCDataSource.setBeanProperty(ds1, "connectionAttributes",
> "create=true");
> Connection conn1 = ds1.getConnection();
> the files created on a server does not get cleaned.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
