[
https://issues.apache.org/jira/browse/DERBY-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mamta A. Satoor updated DERBY-2334:
-----------------------------------
Attachment: DERBY2334_AcceptCollationAttribute_stat_V02.txt
DERBY2334_AcceptCollationAttribute_diff_V02.txt
I have a revised patch for this Jira entry attached as
DERBY2334_AcceptCollationAttribute_diff_V02.txt and svn stat -q attached as
DERBY2334_AcceptCollationAttribute_stat_V02.txt
This patch moves the code for JDBC url attribute collation to boot method in
DataDictionaryImpl.java Once the value for the attribute is validated, it is
converted to database property derby.database.collation. This property will get
saved in the property conglomerate.
The svn stat -q o/p is as follows
M java\engine\org\apache\derby\impl\sql\catalog\DataDictionaryImpl.java
M java\engine\org\apache\derby\iapi\reference\Attribute.java
M java\engine\org\apache\derby\iapi\reference\Property.java
M java\engine\org\apache\derby\jdbc\Driver20.java
M java\engine\org\apache\derby\loc\messages.xml
M java\shared\org\apache\derby\shared\common\reference\SQLState.java
M java\shared\org\apache\derby\shared\common\reference\MessageId.java
M
java\testing\org\apache\derbyTesting\functionTests\master\GetPropertyInfoTest.out
Patch description in brief
1)Changes in DataDictionaryImpl.java will validate the value for the optional
collation attribute and use the default UCS_BASIC if no value supplied (this is
all at database create time). This JDBC url attribute will be saved as database
property derby.database.collation in the property conglomerate.
2)All the JDBC url attributes are defined in Attribute.java. Added collation to
that file.
3)The 2 valid values for collation attribute are defined in Property.java. They
are UCS_BASIC and TERRITORY_BASED. Also, the database property is defined in
this file for collation attribute.
4)Changes in Driver20 class adds the new string attribute so it can be detected
by the generic GUI tools through getPropertyInfo method.
5)Added new SQLState and message id for new attribute in messages.xml,
SQLState.java and MessageId.java
6)Needed to update master GetPropertyInfoTest.out so it is aware of the new
collation attribute.
derbyall ran with no new failures. Junit tests are still running. This is on
Windows XP platform with Sun JDK 1.4
> Accept the new collation attribute and store it in services.properties file.
> Will be used for language based collation ordering.
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2334
> URL: https://issues.apache.org/jira/browse/DERBY-2334
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2334_AcceptCollationAttribute_diff_V01.txt,
> DERBY2334_AcceptCollationAttribute_diff_V02.txt,
> DERBY2334_AcceptCollationAttribute_stat_V01.txt,
> DERBY2334_AcceptCollationAttribute_stat_V02.txt
>
>
> A user would specify the collation desired (UCS_BASIC or
> TERRITORY_BASED_COLLATION) through the new jdbc url attribute - collation.
> This attribute will be used to determine collation ordering for character
> datatypes,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
