[
https://issues.apache.org/jira/browse/DERBY-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476610
]
Øystein Grøvlen commented on DERBY-2257:
----------------------------------------
Patch looks very good. I have one issue that I think needs to be
addressed in a follow-up patch. In your patch, clean-up of the
locator to LOB mapping happens only on explicit calls to commit() and
rollback(). I think clean-up needs to be done in other situations
too. (On auto-commit, when setting the isolation level causes commit
of current transaction, when an error causes a transaction to be
rolled back, and probably some more cases.) Also, it would be nice
with some tests that test the clean-up mechanism.
Some minor nits:
- EmbedConnection.getIncLOBKey(): Why not just use the ++ operator?
- Comments for setUp() of tests says that it does a
getClob/getBlob, but it does not.
- BaseJDBCTestCase has a prepareCall method you can use to prepare
a callable statement on the default connection.
- tearDown(): super.tearDown() will close the connection. Hence,
the subsequent calls to commit and close will work on a new
connection. Also, note that you do not have to do
getConnection() to commit on the default connection. There is
BaseJDBCTestCase.commit() that will do it for you.
> Implementing the stored procedures called by the LOB related JDBC methods
> -------------------------------------------------------------------------
>
> Key: DERBY-2257
> URL: https://issues.apache.org/jira/browse/DERBY-2257
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Environment: All environments
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: Expln_StoredProc_LOB.txt, Expln_StoredProc_LOB_v2.txt,
> StoredProcedure_v3.diff, StoredProcedure_v3.stat, StoredProcedure_v4.diff,
> StoredProcedure_v4.stat, StoredProcedures_v1.diff, StoredProcedures_v1.stat,
> StoredProcedures_v2.diff, StoredProcedures_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
