[ 
https://issues.apache.org/jira/browse/DERBY-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479485
 ] 

Daniel John Debrunner commented on DERBY-2422:
----------------------------------------------

I'm not sure what the method checkResultSet() is trying to check. It's comments 
don't really match its code.
There are already a series of assert for ResultSets in the JDBC utility class, 
could one of those work instead.
If not, then checkResultSet() needs to be cleaned up, e.g. at the moment if 
null is passed in then the assert will pass.

Holdability is supported in JSR169 and JDBC 3, basically all environments Derby 
runs in.

Rather than use a test specific HaveDriverManager the test should be using 
JDBC.vmSupportsJDBC3() since DriverManager is a feature of JDBC 3.

> convert lang/holdCursorjava.java to junit
> -----------------------------------------
>
>                 Key: DERBY-2422
>                 URL: https://issues.apache.org/jira/browse/DERBY-2422
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2422_diff_ver1.txt, DERBY-2422_stat_ver1.txt
>
>
> Place holder for the conversion of the test lang/holdCursorJava.java to junit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to