Manjula Kutty (JIRA) wrote:
[ https://issues.apache.org/jira/browse/DERBY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482190 ]
The comments don't indicate why this test requires JDBC 3? I couldn't see anything obvious that would stop this running on JSR169.
Added comments to to reason why we need JDBC3. Also if I do specify only about
JDBC3, I thought the test will run in JSR 169 (I may be wrong here...Please
clear me if I'm wrong).
I added comments a couple of days ago to the JDBC class to try and
clarify this. But no, vmSupportsJDBC3() says that this virtual machine
supports JDBC 3 in full. Since JSR 169 is a subset of JDBC 3 it is not
true that a virtual machine supporting JSR 169 supports the full JDBC 3
definition.
It looks like the suite method runs the fixtures twice in embedded, once adding them directly and once through defaultSuite
I thought I give
return TestConfiguration.defaultSuite(UnaryArithmeticParameterTest.class);
The test will run both embedded and n/w server mode. (Please correct me if I'm
wrong)
OK, I got confused by your suite method. In the path that returns using
defaultSuite() you also do create a new suite called 'suite'. This suite
is never used though, so that code can be removed. Since the class
didn't compile I couldn't check to see which tests were created.
+ public static Test suite() {
+ if ( !JDBC.vmSupportsJDBC3())
+ return new TestSuite("empty UnaryArithmeticParameterTest -
supported only from JDBC3.0 and above");
+ else{
+ TestSuite suite = new
TestSuite("UnaryArithmeticParameterTest");
+ suite.addTestSuite(UnaryArithmeticParameterTest.class);
+ //To run the test in both embedded and client/server
mode
+ return
TestConfiguration.defaultSuite(UnaryArithmeticParameterTest.class);
+ }
Dan.
