[
https://issues.apache.org/jira/browse/DERBY-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489608
]
Mamta A. Satoor commented on DERBY-2557:
----------------------------------------
Dan had following comment earlier
"I assume this new method is only for returning DVD's, is that correct? If so
could it be declared to return DataValueDescriptor, since it's a method on
DataValueFactory. "
I am not sure what is the right thing to do here. The new method on DVF at this
point is capable of returning more than just a DVD(that is why the return type
is Object) depending on the passed format id. Although Store code is always
going to call this method for format ids associated with DVDs, there is no
check done in the new method to make sure that if a format id passed does not
correspond to DVD, then it should throw an error. The other goal for this
method on DVF was to remove the similar code from
BaseMonitor(newInstanceFromIdentifier) which handles all different kinds of
format ids. If we decide to make the new method on DVF to only deal with DVDs,
then we will need to have code to handle other format ids either in BaseMonitor
or somewhere else. I will like community's feedback on this.
> Provide a new interface on DataValueFactory(DVF) called
> getInstanceUsingFormatIdAndCollationType(formatId, collationType). This api
> will replace similar code in Monitor.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2557
> URL: https://issues.apache.org/jira/browse/DERBY-2557
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt,
> DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt,
> DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_diff.txt,
> DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_stat.txt
>
>
> Provide a new interface, called
> getInstanceUsingFormatIdAndCollationType(formatId, collationType) on DVF.
> Store will call this interface to create empty DVD objects and then load
> these DVD objects using readExternal. For performance efficiency, when Store
> needs more of the same base DVD, then on subsequent needs, it will call
> DVD.getNewNull rather than calling
> DVF.getInstanceUsingFormatIdAndCollationType again. This work is required for
> DERBY-2537.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
