[
https://issues.apache.org/jira/browse/DERBY-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492425
]
Suresh Thalamati commented on DERBY-2527:
-----------------------------------------
Thanks Laura, I read through the sections related to this issue in the PDF
files you attached. Changes looks good, I have few comments :
Derby Reference Manual:
1) In pages 131/133: do we really need the heading "Usage" , it is kind of
misleading to me. Info under is more of detail on how references to
lob are stored in the main import file. Not really usage. May be
it is correct, just thought I will mention it.
Context : Pages 131/ 133
"
Usage
This procedure will read the LOB data using the reference that is stored in the
main
"
2) Examples need to be added for all the new procedures
SYSCS_EXPORT_TABLE_LOBS_TO_EXTFILE , SYSCS_EXPORT_QUERY_LOBS_TO_EXTFILE,
SYSCS_IMPORT_LOBS_FROM_EXTFILE and SYCS_IMPORT_DATA_LOBS_FROM_EXTFILE
3) lobsFileName parameter description needs a small change. It is not updated
in the spec.
In pages 126/ 128:
lobsFileName:
current:
"
Specifies the file that the large object data is exported to. If the path is
omitted, the
current working directory is used."
lob files are created in the same location as the main export if the path is
not specified.
Correct Description should be :
"
Specifies the file that the large object data is exported to. If the path is
omitted, the
lob file is created in the same directory as the main export file."
Derby Tools Guide :
------------------
1) page 28 , in the first paragraph :
"in the main import file in the format lobsFileName.Offset.length, which is the
same way"
a /(slash) is missing the reference format. it should be :
lobsFileName.Offset.length/
2) page 47:
a)
current:
"When you export the data types CHAR FOR BIT DATA, VARCHAR FOR BIT DATA,"
It may be better to say, something like:
"export data from columns of types " instead of "export the data types"
b)
"To import these data types into a table, the data in the import file must be
in the hexadecimal format."
I think, it might be to say:
"To import data into a table, that has columns of these data types, the data in
the
import file for those column must be in the hexadecimal format"
3) In Page 49/50, Great job with table that shows when to use , what
procedure.
you may want to remove the phrase " No result is returned from this
procedure" or
add it to the new procedure cases also, because they also don't return any
result.
In my opinion the phrase does not add any value in this context.
4) On Page 51: I think we should mention user can use
"SYSCS_UTIL.SYSCS_IMPORT_DATA_LOBS_FROM_EXTFILE"
something like :
You can use the SYSCS_UTIL.SYSCS_IMPORT_DATA or
SYSCS_UTIL.SYSCS_IMPORT_DATA_LOBS_FROM_EXTFILE procedures
to import data into a table that contains an identity column.
If the identity column is defined as GENERATED
5) On page : 52 , Same as page 49/50
you may want to remove the phrase " No result is returned from this procedure"
6) On page 53 : Please update the description of the lobsFileName parameter.
"If the path is omitted, the current working directory is used"
should be changed to : "If the path is omitted, the
lob file is created in the same directory as the main export file"
7) On Page 54:
a) Some of the examples have table name lower case as 'staff'
table name in all of the should be in upper case as 'STAFF'
first example :
CALL SYSCS_UTIL.SYSCS_IMPORT_TABLE
(null,'staff','myfile.del',null,null,null,0);
table name shoud be 'STAFF'
please do the same for all the examples in this page.
b) Please add the following two new examples using SYSCS_UTIL.SYSCS_IMPORT_DATA
and
SYSCS_UTIL.SYSCS_IMPORT_DATA_LOBS_FROM_EXTFILE into the example section in the
derby tools guild and also to the reference guide in the appropriate sections.
1)
Example importing only some columns from a delimited file
The following example shows how to import data into only some of the
columns of the staff table in a sample database from a specific columns
in the delimited data file staff.del. This example assumes data in the
import file is formatted using the double quote (") as the string delimiter,
and a comma(,) as the column delimiter. The data will be appended to the
existing data in the table.
CALL SYSCS_UTIL.SYSCS_IMPORT_DATA(NULL, 'STAFF',
'NAME,DEPT,SALARY', '2,3,4', 'c:\data\staff.del',',','"','UTF-8', 0)
2)
Example importing data into only some columns from both a main import file
that contains references that point to a separate file that contains LOB data
The following example shows how to import data into some columns of
the STAFF table, which includes a LOB column in a sample database from a
delimited data file staff.del, which has references to LOB data in an
external file.
This example assumes data in the import file is formatted using
double quote (") as the string delimiter, and a comma(,) as the
column delimiter. The data will be appended to the existing data
in the table.
CALL SYSCS_UTIL.SYSCS_IMPORT_DATA_LOBS_FROM_EXTFILE(NULL, 'STAFF',
'NAME,DEPT,SALARY,PICTURE', '2,3,4,6', 'c:\data\staff.del', ',','"','UTF-8',
0)
--
> Add documentation for import/export of LOBS and other binary data types.
> ---------------------------------------------------------------------------
>
> Key: DERBY-2527
> URL: https://issues.apache.org/jira/browse/DERBY-2527
> Project: Derby
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 10.3.0.0
> Reporter: Suresh Thalamati
> Assigned To: Laura Stewart
> Attachments: derbytools.pdf, iexlobs_v1.txt, refderby.pdf
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
