[
https://issues.apache.org/jira/browse/DERBY-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498870
]
A B commented on DERBY-2654:
----------------------------
Thanks for picking this one up, Kim. The changes look good. Just three minor
comments:
1) rrefjdbcjavasqlconnection30.html:
There's a slight glitch in the last row. I think "Column indexes" should be
replaced with "Column names".
2) rrefjdbcjavasqlstatement30.html:
I had a typo in my original changes. Can you replace "columns" with "keys" in
the following
sentence (first row of the table):
"If the user has indicated that auto-generated columns ..."
And once that's done, can we link "auto-generated keys" to the relevant page,
i.e. to
crefjavstateautogen.html? Or would that be too many redundant links for one
page?
3) The "Connection" page ends with:
For more information, see Autogenerated keys.
while the "Statement" page ends with a simple bullet:
* Autogenerated keys
Is it be possible to make the two consistent? Or perhaps this link should just
go under the "Related reference" list? I'm not sure what the best approach is,
but I do think it'd be nice to have consistency between the two pages.
Other than that I have no other comments. Thanks again for your quick work on
this!
> Document newly-supported (in embedded mode) JDBC methods for autogenerated
> keys.
> --------------------------------------------------------------------------------
>
> Key: DERBY-2654
> URL: https://issues.apache.org/jira/browse/DERBY-2654
> Project: Derby
> Issue Type: Sub-task
> Components: Documentation
> Affects Versions: 10.3.0.0
> Reporter: A B
> Assigned To: Kim Haase
> Attachments: changes.txt, changes.txt, DERBY-2654.diff, DERBY-2654.zip
>
>
> Several JDBC methods for specifying auto-generated key columns were
> implemented in embedded mode as part of DERBY-2631. Derby documentation
> should be updated to reflect those changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
