[
https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502869
]
A B commented on DERBY-1623:
----------------------------
> Addresses all the issues raised by A. B.
Thanks for the updated patch, Manish. It looks good to me, with the exception
of some minor formatting glitches (lines longer than 80 chars and tab/space
mixups) that I can perhaps fix before committing.
There are still two questions that have yet to be answered:
6. Is the "trim(...)" method on StringDataValue still used anywhere after
these changes?
8. Do you have any plans to document this new function?
Also, if this is going into 10.3 then I think it should be listed on the "buddy
testing" wiki page for 10.3, correct?
http://wiki.apache.org/db-derby/TenThreeBuddyTesting
> Add ANSI TRIM implementation
> ----------------------------
>
> Key: DERBY-1623
> URL: https://issues.apache.org/jira/browse/DERBY-1623
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Emmanuel Bernard
> Assignee: Manish Khettry
> Attachments: 1623-parser-guess.diff, 1623.patch.txt,
> 1623_take2.patch.txt, AnsiTrimTest.java, compile_error.jj, sqlgrammar.jj.diff
>
>
> JPA is requiring databases to support this ANSI feature esp the ability to
> chose the trimmed character
> TRIM([ [ LEADING | TRAILING | BOTH ] [ chars ] FROM ] str)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
