[
https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514196
]
Øystein Grøvlen commented on DERBY-2954:
----------------------------------------
I have a few comments to the syntax chosen for the
NetworkServerControl commands. I think it is important that the new
commands are well aligned with existing commands in order to give a
uniform and consistent view.
1. I see that you have chosen to have single replication commands with
subcommands for the different replication operations. An
alternative would be to have different top level commands
(e.g., startmaster, startslave, failover, stopreplication). Do you
have a rationale for your decision? I am not quite sure what is
best choice.
2. If you stick with the two level commands, I think you should not
use '-' in front of the sub level commands. I think these should
be viewed as commands, not options. If you look at existing
commands, the main arguments are usually not handled as options.
(e.g., logconnections, maxthreads, timeslice, trace)
3. Syntax for options: The use of '=' is different from the existing
syntax.
4. All existing commands have the [-h <host>][-p <portnumber>]. I
think you could also use those instead of your proposed -url and
-port options.
> Add commands to NetworkServerControl for interacting with the replication
> functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
