[
https://issues.apache.org/jira/browse/DERBY-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
V.Narayanan updated DERBY-2954:
-------------------------------
Attachment: NetworkServerControlCmds_v3.stat
NetworkServerControlCmds_v3.diff
Thank you for the reviews and comments Oystein
v3 addresses all the issues pointed out in v2 of the patch
I addressed 1) by catching the NumberFormatException
that is thrown upon parsing for an integer in a String
containing an unexpected alpha-numeric along the same
lines of what happens currently for -h and -p dashed arguments.
I addressed 2) by adding a check in the findCommands
method that parses the arguments passed to
NetworkServerControl class to ensure that the length of
the command passed in greater than 0.
I have addressed all the other issues pointed out also.
I have not yet run tests on this patch and shall post
the results of the test run tomorrow.
I request for this patch to be considered for comments and reviews.
> Add commands to NetworkServerControl for interacting with the replication
> functionality
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-2954
> URL: https://issues.apache.org/jira/browse/DERBY-2954
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.4.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: NetworkServerControlCmds_v1.diff,
> NetworkServerControlCmds_v1.stat, NetworkServerControlCmds_v2.diff,
> NetworkServerControlCmds_v2.stat, NetworkServerControlCmds_v3.diff,
> NetworkServerControlCmds_v3.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
