[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531728
]
Øystein Grøvlen commented on DERBY-3064:
----------------------------------------
All looks very good, except that it seems I did not explain what I
meant in comment 14 well enough. I suggest shipALogChunk and
forceFlush does NOT call handleExceptions, nor catch exceptions they
are not going to deal with. In other words, I think all exceptions
except the NoSuchElementExcpetion should not be caught, but left to
the caller (the log shipper thread or the master controller to deal
with).
In addition, I have a few VERY minor comments:
- Import of PriviligedActionException is no longer needed
- mesg does no longer need to be declared outside the loop
- It is probably good to explain why NoSuchElementExcpetion is fatal.
- Why create a new SQLState? Could not XRE03 be used?
> Implement the LogShipper that will enable the shipping of Log records from
> the master to the slave
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3064
> URL: https://issues.apache.org/jira/browse/DERBY-3064
> Project: Derby
> Issue Type: Sub-task
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: LogShipperImpl_v1.diff, LogShipperImpl_v1.stat,
> LogShipperImpl_v2.diff, LogShipperImpl_v2.stat, LogShipperImpl_v3.diff,
> LogShipperImpl_v3.stat, LogShipperImpl_v4.diff, LogShipperImpl_v4.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
