[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547767
]
Øystein Grøvlen commented on DERBY-3064:
----------------------------------------
Thanks, for the patch Narayanan. Most of my comments are just
cosmetical issues:
9. MasterController:
a) I think startMaster() needs to have a timeout for how long it
should wait before it tells the caller that it was not able to
connect to the slave.
b) setupConnection(): I am not sure, but will it always be OK to
not to propagate the content of IOExcpetion? Will there never
be any interesting info that could help a user diagnose why a
connection is not established?
c) Unused imports: PrivilegedActionException, ErrorStringBuilder
d) Class declaration: Non-intuitive breakage of lines for
implements/extends.
e) Unnecessary white-space diff after declaration of
DEFAULT_LOG_BUFFER_SIZE.
f) I agree that setUpConnection should be moved, but it is still in
the wrong place (under methods from ModuleSupportable interface)
g) I think the JavaDoc for handleExceptions should say that it only
handles IOException and StandardException.
10. AsynchronousLogShipper
a) I do not understand why you let the LogShipper continue after it
is has been interrupted. It seems like interrupt is only used
when the thread is to be terminated. Maybe you should just
terminate the thread here.
b) What is the purpose of stopLogShipment()? It does not seem to
stop the LogShipper from sending log anymore. I do not
understand why you have changed run() to 'while(true)' instead
of 'while(!stopShipping)'.
11. messages.xml
a) I think messages needs to have a parameter for database name
(slave messages does). If the master is replication several
databases, the users needs to be told which one has terminated.
b) Last message name should be R010, not R008.
> Implement the LogShipper that will enable the shipping of Log records from
> the master to the slave
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3064
> URL: https://issues.apache.org/jira/browse/DERBY-3064
> Project: Derby
> Issue Type: Sub-task
> Components: Miscellaneous
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: LogShipperImpl_v1.diff, LogShipperImpl_v1.stat,
> LogShipperImpl_v2.diff, LogShipperImpl_v2.stat, LogShipperImpl_v3.diff,
> LogShipperImpl_v3.stat, LogShipperImpl_v4.diff, LogShipperImpl_v4.stat,
> LogShipperImpl_v5.diff, LogShipperImpl_v5.stat,
> LogShipperIntegration_v1.diff, LogShipperIntegration_v1.stat,
> LogShipperIntegration_v2.diff, LogShipperIntegration_v2.stat,
> LogShipperIntegration_v3.diff, LogShipperIntegration_v3.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
