[
https://issues.apache.org/jira/browse/DERBY-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533295
]
Knut Anders Hatlen commented on DERBY-3117:
-------------------------------------------
Thanks for updating the patch, Rick. Looks great now. A couple of nits, though:
1) Two blanks between 'such' and 'that':
+ The Derby build is set up such that most of
2) Long line (> 80):
+ with Sun's JDK 1.4.2 libraries, and with Ant 1.6.1. The Derby build
environment
3) Should 'shell window' be replaced with 'ant process' in the text below?
+You must also install the Java 5 (or later) JDK and this must be the version of
+Java used by the shell window in which you run the Derby build. You
You're not required to run the build process in a shell window, and it is the
value of JAVA_HOME that decides which java version ant uses, I think. (At least
I was not able to build Derby when 'java -version' in the shell window said
version 1.6.0 and JAVA_HOME pointed to a JDK 1.3 installation, and I was able
to build Derby when 'java -version' said version 1.3.1 and JAVA_HOME pointed to
1.6.)
4) Replace 'Java 6 JDK' with 'Java 5 JDK' in the text below:
+(6) The directory where you have installed the Java 6 JDK will be
+ referred to as ${java5.dir} in the rest of this document.
> Adjust master build script to require the Java 5 compiler to build Derby
> ------------------------------------------------------------------------
>
> Key: DERBY-3117
> URL: https://issues.apache.org/jira/browse/DERBY-3117
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-3117-01-enforceJava5-aa.diff,
> derby-3117-01-enforceJava5-ab.diff
>
>
> Require the Java 5 compiler in order to build Derby as approved by the
> community recently:
> http://www.nabble.com/-VOTE--Require-Java-5-%28or-later%29-compiler-to-build-Derby-tf4522491.html#a13030783
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
