[
https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535775
]
Rick Hillegas commented on DERBY-1387:
--------------------------------------
Thanks for rev 7 of the patch, Bernt. A couple more comments:
1) MDatabase.checkTableConsistency() - If this method is going to
return a String rather than a boolean, then I wonder if the failure
case should just return the message from the exception--rather than
repackaging that message as a SQLException.
2) MDatabase.getProperty() - This method seems to map states
to strings as follows:
SQLException -> silently swallowed and replaced with a default value
Property not set -> default value
Property is set -> its value
Not connected to database -> the string "N/A"
I think that mapping the first two states to the same outcome may turn
out to be confusing.
3) MDatabase.getStorageTempDirectory() - What is the default returned
by this method? Is STORAGE_TEMP_DIRECTORY always supposed to be set?
If not, this method seems to return a misleading default.
4) DerbySystemMBean.setStoragePageSize() - I think that the conversion
of 4k, 8k, 16k, and 32k to stringified integers should happen before the initial
check for legal values. As it stands, I don't think the conversion
will ever be executed.
> Add JMX extensions to Derby
> ---------------------------
>
> Key: DERBY-1387
> URL: https://issues.apache.org/jira/browse/DERBY-1387
> Project: Derby
> Issue Type: New Feature
> Components: Services
> Reporter: Sanket Sharma
> Assignee: Bernt M. Johnsen
> Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff,
> DERBY-1387-2.stat, DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff,
> DERBY-1387-4.stat, DERBY-1387-5.diff, DERBY-1387-5.stat, DERBY-1387-6.zip,
> DERBY-1387-7.zip, derbyjmx.patch, jmx.diff, jmx.stat, jmxFuncspec.html,
> Requirements for JMX Updated.html, Requirements for JMX.html, Requirements
> for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and
> management extensions to Apache Derby using JMX. The requirements document
> has been uploaded on JIRA as well as the Derby Wiki page at
> http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature
> list in particular) and add their own rating to features by adding a coloumn
> to the table.
> Comments are welcome.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
