[
https://issues.apache.org/jira/browse/DERBY-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547732
]
Martin Zaun commented on DERBY-927:
-----------------------------------
A particular line of code
java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java:1086
very much looks like a copy&paste bug to me:
private Vector getImplementations(Properties moduleList, boolean
actualModuleList) {
...
if (key.startsWith(Property.MODULE_PREFIX)) {
tag = key.substring(Property.MODULE_PREFIX.length());
} else if (key.startsWith(Property.SUB_SUB_PROTOCOL_PREFIX)) {
tag = key.substring(Property.MODULE_PREFIX.length());
^^^^^^^^^^^^^
I guess MODULE_PREFIX was meant to be replaced with SUB_SUB_PROTOCOL_PREFIX.
} ...
> Cleanup code in the monitor to clarify the relationship between
> StorageFactory and PersistentService
> ----------------------------------------------------------------------------------------------------
>
> Key: DERBY-927
> URL: https://issues.apache.org/jira/browse/DERBY-927
> Project: Derby
> Issue Type: Improvement
> Components: Services
> Reporter: Daniel John Debrunner
> Assignee: Daniel John Debrunner
> Priority: Minor
>
> The addition of the StorageFactory code into the BaseMonitor code muddied the
> water with respect to what is a service and what is a storage factory.
> Cleanup the code and add comments and/or a package.html to describe what is
> going on.
> Look at loading the storage factories through the modules.properties rather
> than the hard-coded list and thus gain the benefit of the standard module
> environment
> checking (jvm level and dependent classes) and ensure classes are loaded from
> modules.properties consistently.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
