Reason for errors in the tinderbox test? (Re: svn commit: r612525 [1/2])

[Kristian Waagan]

Hello,

I haven't looked much into this, but I suspect this commit broke several 
tests.
Based on a *very* quick look at the diff only, I think the removal of 
national character code was a little too broad.
For instance, the JDBC layer needs to know about these types to be able 
to throw not-supported exceptions (a possible place to start checking - 
see changes for PreparedStatement).
Note that to get the errors, you will have to run with Java SE 6.

--
Kristian

[EMAIL PROTECTED] skrev:
Author: mamta
Date: Wed Jan 16 09:29:02 2008
New Revision: 612525

URL: http://svn.apache.org/viewvc?rev=612525&view=rev
Log:
DERBY-2720 and DERBY-3315
Removing the disabled national character related code. This will make it easy 
to maintain
the territory based code.


Removed:
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNClob.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNationalChar.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNationalLongvarchar.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNationalVarchar.java
Modified:
    
db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java
    db/derby/code/trunk/java/client/org/apache/derby/client/am/Types.java
    
db/derby/code/trunk/java/engine/org/apache/derby/catalog/types/BaseTypeIdImpl.java
    
db/derby/code/trunk/java/engine/org/apache/derby/catalog/types/TypeDescriptorImpl.java
    
db/derby/code/trunk/java/engine/org/apache/derby/catalog/types/TypesImplInstanceGetter.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/services/io/RegisteredFormatIds.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/services/io/StoredFormatIds.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/compile/C_NodeTypes.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/compile/TypeCompiler.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DTSClassInfo.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java
    
db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactoryImpl.java
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/Like.java
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLChar.java
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/Util.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/BaseTypeCompiler.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/BinaryComparisonOperatorNode.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CLOBTypeCompiler.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CharTypeCompiler.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ColumnDefinitionNode.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/LikeEscapeOperatorNode.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ModifyColumnNode.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
    
db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TypeCompilerFactoryImpl.java

  
[ snip ]