[ 
https://issues.apache.org/jira/browse/DERBY-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560520#action_12560520
 ] 

oysteing edited comment on DERBY-3254 at 1/18/08 1:58 PM:
-----------------------------------------------------------------

With the latest patch,  failover_impl_v4.diff , I get an error in the 
ErrorCodeTest. 
It is probably related to the fact that a database severity error as been added.

While fixing this, here is some minor issues that should also be addressed:

 - Update javadoc of MasterFactory/MasterController#startFailover to indicate 
that it will throw an exception also on success.
 - Some unecessary imports (Property, SQLException)
 - The text of the javadoc for LogToFile#stopReplicationSlaveRole could still 
be improved.

      was (Author: oysteing):
    With the latest patch,  failover_impl_v4.diff , I get an error in the error 
code test. 
It is probably related to the fact that a database severity error as been added.

While fixing this, here is some minor issues that should also be addressed:

 - Update javadoc of MasterFactory/MasterController#startFailover to indicate 
that it will throw an exception also on success.
 - Some unecessary imports (Property, SQLException)
 - The text of the javadoc for LogToFile#stopReplicationSlaveRole could still 
be improved.
  
> Implement the replication failover functionality
> ------------------------------------------------
>
>                 Key: DERBY-3254
>                 URL: https://issues.apache.org/jira/browse/DERBY-3254
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: failover_impl_notforcommit.diff, 
> failover_impl_notforcommit.stat, failover_impl_v1.diff, 
> failover_impl_v1.stat, failover_impl_v2.diff, failover_impl_v2.stat, 
> failover_impl_v3.diff, failover_impl_v3.stat, failover_impl_v4.diff, 
> failover_impl_v4.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to