[
https://issues.apache.org/jira/browse/DERBY-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560983#action_12560983
]
Øystein Grøvlen commented on DERBY-3254:
----------------------------------------
I do not understand the change to MasterController#startFailover. It seems
like handleFailoverFailure will be called in all cases now. Also, exceptions
thrown by handleFailoverFailure called from the try block, will be caught and
passed to handeFailoverFailure by the catch block. That seems a bit
unnecessary. I think the whole handling of ack, as it was in v4 of the patch,
should be moved outside the try block.
> Implement the replication failover functionality
> ------------------------------------------------
>
> Key: DERBY-3254
> URL: https://issues.apache.org/jira/browse/DERBY-3254
> Project: Derby
> Issue Type: Sub-task
> Components: Replication
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: failover_impl_notforcommit.diff,
> failover_impl_notforcommit.stat, failover_impl_v1.diff,
> failover_impl_v1.stat, failover_impl_v2.diff, failover_impl_v2.stat,
> failover_impl_v3.diff, failover_impl_v3.stat, failover_impl_v4.diff,
> failover_impl_v4.stat, failover_impl_v5.diff, failover_impl_v5.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
