[ 
https://issues.apache.org/jira/browse/DERBY-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560555#action_12560555
 ] 

Daniel John Debrunner commented on DERBY-3323:
----------------------------------------------

> With revision 613275 I changed the test to close the last ResultSet and force 
> a gc().

Adding the forced gc() seems to be a case of making the test pass rather than 
fixing a potential bug.

Adding a gc() to the test is really saying it's part of the api, and thus this 
is what applications need  to do as well. Since this is not what is required 
(ie. we don't want to have to say in order to run Derby successfully you need 
to force gc() once in a while), can we remove the gc() and then fix the bug if 
the problem remains?

Even closing the ResultSet has the feel of making the test pass rather than 
fixing a potential bug. Is there a valid explanation for why holding this 
result set open stops the table being dropped? If there is then it's acceptable 
to close the result set, but if the ResultSet being open should have no effect 
on the DROP TABLE then we are merely avoiding seeing a bug by closing the 
ResultSet.

> ComparisonFailure in derbyStress
> --------------------------------
>
>                 Key: DERBY-3323
>                 URL: https://issues.apache.org/jira/browse/DERBY-3323
>             Project: Derby
>          Issue Type: Bug
>          Components: Regression Test Failure
>    Affects Versions: 10.4.0.0
>         Environment: jvm1.4 lin
> jvm1.5 lin, linN+1
> vm1.6 sles,sol, solN+1
> jvm1.5 w2003
>            Reporter: Ole Solberg
>            Assignee: Kathey Marsden
>            Priority: Minor
>
> See 
> jvm1.4 lin : 
> http://dbtg.thresher.com/derby/test/Daily/jvm1.4/FailReports/612516_bySig.html
> jvm1.5 lin, jvm1.5 linN+1 : 
> http://dbtg.thresher.com/derby/test/Daily/jvm1.5/FailReports/612516_bySig.html
> jvm1.6 sles, jvm1.6 sol, jvm1.6 solN+1: 
> http://dbtg.thresher.com/derby/test/Daily/jvm1.6/FailReports/612516_bySig.html
> jvm1.5 w2003: 
> http://dbtg.thresher.com/derby/test/10.3Branch/jvm1.5/FailReports/612526_bySig.html
> 1) 
> derbyStress(org.apache.derbyTesting.functionTests.tests.jdbcapi.JDBCHarnessJavaTest)junit.framework.ComparisonFailure:
>  Output at line 6 expected:<[Test derbyStress finished.]> but was:<[FAIL -- 
> unexpected exception ****************]>
>       at 
> org.apache.derbyTesting.functionTests.util.CanonTestCase.compareCanon(CanonTestCase.java:100)
>       at 
> org.apache.derbyTesting.functionTests.util.HarnessJavaTest.runTest(HarnessJavaTest.java:91)
>       at 
> org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:96)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>       at junit.extensions.TestSetup.run(TestSetup.java:25)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>       at junit.extensions.TestSetup.run(TestSetup.java:25)
>       at 
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
>       at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>       at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>       at junit.extensions.TestSetup.run(TestSetup.java:25)
>       at 
> org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to