[ 
https://issues.apache.org/jira/browse/DERBY-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565731#action_12565731
 ] 

Knut Anders Hatlen commented on DERBY-3324:
-------------------------------------------

The asserts look fine to me, and they reduce the risk of mixing up the 
arguments. +1 to commit.

> JDBC statement cache implementation
> -----------------------------------
>
>                 Key: DERBY-3324
>                 URL: https://issues.apache.org/jira/browse/DERBY-3324
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3324-1a-jdbc_statementcache.diff, 
> derby-3324-1a-jdbc_statementcache.stat, 
> derby-3324-1b-jdbc_statementcache.diff, 
> derby-3324-1b-jdbc_statementcache.stat, 
> derby-3324-1c-jdbc_statementcache.diff, 
> derby-3324-1c-jdbc_statementcache.stat, 
> derby-3324-1d-jdbc_statementcache.diff, 
> derby-3324-1e-jdbc_statementcache.diff, 
> derby-3324-2a_argument_reordering.diff, 
> derby-3324-3a_argument_reordering_additional.diff, 
> derby-3324-4a-statementkey_asserts.diff
>
>
> Implement a cache for storing JDBC prepared statement objects.
> The cache will be responsible for holding free prepared statement objects 
> that can be reused, and also to throw away objects if the cache grows too big.
> All objects in the cache must belong to the same physical connection, but 
> they can be reused across logical connections obtained from a single physical 
> connection in a connection pool.
> This component is probably a candidate for code sharing between the client 
> and the embedded driver. Sharing will not  be part of this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to