[
https://issues.apache.org/jira/browse/DERBY-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566407#action_12566407
]
Daniel John Debrunner commented on DERBY-2667:
----------------------------------------------
It would be good to add comments to the code so that it's clear to readers what
the purpose of the code is.
The streams for the files don't seem to get closed.
The caught exception is never re-thrown, so this will hide any failures.
Fetching the property user.dir is likely to result in a security exception
since it's not in a priv block,
the class has a utility method for reading system properties, but it's not
needed since one does
not need to read user.dir to access files in the current directory. Something
like new File("system", "derby.log") should work.
Also it would be good to test that the file derby.log exists, it's not
guaranteed that a test will create it.
Also probably better not to construct file paths using File.separator, instead
use File objects.
> Create more robust junit TestRunner for running derby tests
> ------------------------------------------------------------
>
> Key: DERBY-2667
> URL: https://issues.apache.org/jira/browse/DERBY-2667
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: DERBY-2667_diff_02_06.txt, DERBY-2667_stat_02_06.txt,
> JUnitMethodTrace.diff.txt, JUnitMethodTrace_Extra.diff.txt, MemRunner.java,
> TimeRunner.java
>
>
> Provide a more full featured TestRunner for Derby testing.
> junit.textui.TestRunner is not very robust. It does not for example print the
> tests as they run or print chained exceptions, create separate files for the
> full report and just failures. It would be great to have a standardized
> TestRunner that everyone uses. Perhaps someone already has one that they
> would like to contribute as a starter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
