[
https://issues.apache.org/jira/browse/DERBY-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570179#action_12570179
]
Knut Anders Hatlen commented on DERBY-2667:
-------------------------------------------
The check of testDir.exists() looks misplaced. If it returns false, the
construction of a FileInputStream would have failed with FileNotFoundException
two lines above it.
Also, I think it would be best only to create the FileOutputStream if testDir
exists. Otherwise, we'll create an empty file for each failing test that
doesn't have a derby.log file.
Many of the lines use a mix of tabs and spaces for indentation.
Should new File("System", "derby.log"); use "system" instead? I don't think it
will work on case-sensitive file systems, since the directory created by the
framework is called "system".
> Create more robust junit TestRunner for running derby tests
> ------------------------------------------------------------
>
> Key: DERBY-2667
> URL: https://issues.apache.org/jira/browse/DERBY-2667
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.3.1.4
> Reporter: Kathey Marsden
> Priority: Minor
> Attachments: DERBY-2667_diff_02_06.txt, DERBY-2667_diff_02_15.txt,
> DERBY-2667_stat_02_06.txt, DERBY-2667_stat_02_15.txt,
> JUnitMethodTrace.diff.txt, JUnitMethodTrace_Extra.diff.txt, MemRunner.java,
> TimeRunner.java
>
>
> Provide a more full featured TestRunner for Derby testing.
> junit.textui.TestRunner is not very robust. It does not for example print the
> tests as they run or print chained exceptions, create separate files for the
> full report and just failures. It would be great to have a standardized
> TestRunner that everyone uses. Perhaps someone already has one that they
> would like to contribute as a starter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
