[
https://issues.apache.org/jira/browse/DERBY-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572145#action_12572145
]
Daniel John Debrunner commented on DERBY-3453:
----------------------------------------------
Will org.apache.derby.iapi.jdbc be the correct location for EmbedSQLWarning?
It's used by the language code, but I understand a goal of yours is to not have
the language code depend on the jdbcapi layer.
EmbedSQLWarning is really a factory class to return SQLWarning objects, and it
should return plain java.sql.SQLWarning objects rather than a Derby specific
implementation. Assume a re-name to SQLWarningFactory, then it would depend on
only on the message service. Since this is really related to error handling
should SQLWarningFactory belong in org.apache.derby.iapi.error?
I think the EmbedSQLWarning cleanup should be a separate issue.
PublicAPI may also benefit from any improvement not to use EmbedSQLException,
thus it may be worth addressing that first.
Also the replication code is using PublicAPI but seems to be changing its
approach, thus it may be better to hold off this patch until that code has been
updated.
> The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles
> creation of SQLException
> ------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3453
> URL: https://issues.apache.org/jira/browse/DERBY-3453
> Project: Derby
> Issue Type: Sub-task
> Reporter: Dibyendu Majumdar
> Assignee: Dibyendu Majumdar
> Attachments: DERBY-3453_patch_rev630512.txt
>
>
> The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles
> creation of SQLException.
> The classes EmbedSQLException and EmbedSQLWarning are better placed in
> org.apache.derby.iapi.jdbc. These classes are referenced outside the jdbc
> module.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
