[ 
https://issues.apache.org/jira/browse/DERBY-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572311#action_12572311
 ] 

Dibyendu Majumdar commented on DERBY-3453:
------------------------------------------

Okay, I will separate the EmbedSQLWarning into a separate cleanup. If the only 
dependency is on a standard java library class, then o.a.d.iapi.error is a good 
package for the renamed class.

I think that the whole business of EmbedSQLException, EmbedSQLWarning, 
PublicAPI, and o.a.d.impl.jdbc.Util needs to be looked at. But, rather than 
making big revisions, I wanted to make small incremental changes. I am sure 
that as I work my way up the layers, more re-factoring will be necessary.

Would the proposed changes to PublicAPI and EmbedSQLException be acceptable as 
interim changes?


> The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles 
> creation of SQLException
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3453
>                 URL: https://issues.apache.org/jira/browse/DERBY-3453
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Dibyendu Majumdar
>            Assignee: Dibyendu Majumdar
>         Attachments: DERBY-3453_patch_rev630512.txt
>
>
> The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles 
> creation of SQLException.
> The classes EmbedSQLException and EmbedSQLWarning are better placed in 
> org.apache.derby.iapi.jdbc. These classes are referenced outside the jdbc 
> module.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to