[ 
https://issues.apache.org/jira/browse/DERBY-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577804#action_12577804
 ] 

Kristian Waagan commented on DERBY-3525:
----------------------------------------

It is not clear to me why the component includes "Network Client".
If it was not just a click too much, do you mind explaining how this affects 
the network client?

> Remove unneeded code to get JDBC level in BrokeredConnection and 
> BrokeredStatement classes
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3525
>                 URL: https://issues.apache.org/jira/browse/DERBY-3525
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, Network Client
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Priority: Minor
>
> BrokeredConnection has a method called getJDBCLevel() whose only purpose is 
> to provide a value that can be stored in BrokeredStatement.jdbcLevel. This 
> field is only used once, in BrokeredStatement.createDuplicateStatement():
>               if (jdbcLevel == 2)
>                       newStatement = conn.createStatement(resultSetType, 
> resultSetConcurrency);
>               else
>                       newStatement = conn.createStatement(resultSetType, 
> resultSetConcurrency,
>                     resultSetHoldability);
> Since getJDBCLevel() only returns 2 if Java version 1.3 is used, and Derby 
> doesn't support Java 1.3 any more, BrokeredConnection.getJDBCLevel() and 
> BrokeredStatement.jdbcLevel could be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to