[
https://issues.apache.org/jira/browse/DERBY-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578174#action_12578174
]
Knut Anders Hatlen commented on DERBY-3525:
-------------------------------------------
derby-3525_diff.txt looks good. +1 to commit.
I agree that BrokeredConnection30 should also be removed. Probably OK to do it
as part of this issue. (Actually, I think most of the *30 classes could be
removed now, but that's outside the scope of this issue.)
> Remove unneeded code to get JDBC level in BrokeredConnection and
> BrokeredStatement classes
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-3525
> URL: https://issues.apache.org/jira/browse/DERBY-3525
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.5.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-3525_diff.txt
>
>
> BrokeredConnection has a method called getJDBCLevel() whose only purpose is
> to provide a value that can be stored in BrokeredStatement.jdbcLevel. This
> field is only used once, in BrokeredStatement.createDuplicateStatement():
> if (jdbcLevel == 2)
> newStatement = conn.createStatement(resultSetType,
> resultSetConcurrency);
> else
> newStatement = conn.createStatement(resultSetType,
> resultSetConcurrency,
> resultSetHoldability);
> Since getJDBCLevel() only returns 2 if Java version 1.3 is used, and Derby
> doesn't support Java 1.3 any more, BrokeredConnection.getJDBCLevel() and
> BrokeredStatement.jdbcLevel could be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
