[
https://issues.apache.org/jira/browse/DERBY-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581159#action_12581159
]
Øystein Grøvlen commented on DERBY-3551:
----------------------------------------
Since I guess unlogged operations will be blocked when the database is frozen,
I think it will be safe to delay the check until starting the master.
I think the proposed patch looks good. Do you plan to add some test cases?
Some suggestions on wording:
* LogToFile#replicationLogUnlogged: This method returns whether db is in
master mode or not, and I think inReplicationMasterMode or something would be a
better name. (The way the javadoc is written, it may lead you to think that
you should call this method to activate logging.)
* messages.xml: I would say 'cannot be started' , not 'booted' since the
operation is called startMaster.'
> Implement procedure SYSCS_UTIL.SYSCS_PREPARE_REPLICATION()
> ----------------------------------------------------------
>
> Key: DERBY-3551
> URL: https://issues.apache.org/jira/browse/DERBY-3551
> Project: Derby
> Issue Type: Sub-task
> Components: Replication
> Affects Versions: 10.4.0.0, 10.5.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3551_1.diff, Derby3551_1.stat, Derby3551_2.diff,
> Derby3551_2.stat, runscript_import.sql
>
>
> Jorgen says-
> I suggest that the replication step in which the master database is frozen is
> replaced by a new system procedure to solve index and import:
> Old: SYSCS_UTIL.SYSCS_FREEZE_DATABASE()
> New: SYSCS_UTIL.SYSCS_PREPARE_REPLICATION()
> The new system procedure should:
> 1) Freeze the database
> 2) Check if there are any ongoing transactions with unlogged operations. If
> so - unfreeze and abort. Otherwise:
> 3) Enable logging of unlogged operations
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
