[
https://issues.apache.org/jira/browse/DERBY-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
V.Narayanan updated DERBY-3551:
-------------------------------
Attachment: Derby3551_3.stat
Derby3551_3.diff
> Since I guess unlogged operations will be blocked when the database is
> frozen,
> I think it will be safe to delay the check until starting the master.
correct, That is why I thought that a combination of the steps, the user should
follow
and a check to see if the freeze has frozen any already started unlogged
operation, should
suffice.
> I think the proposed patch looks good. Do you plan to add some test cases?
I intend to add tests in http://issues.apache.org/jira/browse/Derby-3553. I was
hoping
to move to installation of jars and look at what will be required there and
then move to
writing tests for unlogged operations.
> * LogToFile#replicationLogUnlogged: This method returns whether db is in
> master
> mode or not, and I think inReplicationMasterMode or something would be a
> better name.
> (The way the javadoc is written, it may lead you to think that you should
> call this method to
> activate logging.)
Changed the method name to inReplicationMasterMode(). I also changed the
javadoc to the following
* Used to determine if the replication master mode has been started,
* and the logging for unlogged operations needs to be enabled.
> * messages.xml: I would say 'cannot be started' , not 'booted' since the
> operation is called
> startMaster.'
Changed 'booted' to 'started'.
> Implement procedure SYSCS_UTIL.SYSCS_PREPARE_REPLICATION()
> ----------------------------------------------------------
>
> Key: DERBY-3551
> URL: https://issues.apache.org/jira/browse/DERBY-3551
> Project: Derby
> Issue Type: Sub-task
> Components: Replication
> Affects Versions: 10.4.0.0, 10.5.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: Derby3551_1.diff, Derby3551_1.stat, Derby3551_2.diff,
> Derby3551_2.stat, Derby3551_3.diff, Derby3551_3.stat, runscript_import.sql
>
>
> Jorgen says-
> I suggest that the replication step in which the master database is frozen is
> replaced by a new system procedure to solve index and import:
> Old: SYSCS_UTIL.SYSCS_FREEZE_DATABASE()
> New: SYSCS_UTIL.SYSCS_PREPARE_REPLICATION()
> The new system procedure should:
> 1) Freeze the database
> 2) Check if there are any ongoing transactions with unlogged operations. If
> so - unfreeze and abort. Otherwise:
> 3) Enable logging of unlogged operations
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
