[ 
https://issues.apache.org/jira/browse/DERBY-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

V.Narayanan updated DERBY-3489:
-------------------------------

    Attachment: Derby3489_3.stat
                Derby3489_3.diff

Thank you for the comments/reviews Oystein!

I have addressed all the issues pointed out.

I have verified that this patch works for default values in both Master and 
Slave before
making the following changes

>- ReplicationMessageReceive constructor: Parameter dbname is no
>   longer used
>
>- ReplicationMessageReceive: Import of UnknownHostException no longer
>  necessary.
>
>- MessageId: Does not seem to contain any significant change.

But since these changes were more or less minor and would not have affected
code flow I thought it is safe and the verification does not need to be done 
again
after making these changes.

Master
------

ij version 10.5
ij> connect 'jdbc:derby://localhost:1527/replicationdb';
ij> connect 
'jdbc:derby://localhost:1527/replicationdb;startMaster=true;slaveHost=localhost';
ij(CONNECTION1)> create table narayanan(age int, name varchar(30));
0 rows inserted/updated/deleted
ij(CONNECTION1)> connect 
'jdbc:derby://localhost:1527/replicationdb;failover=true';
ERROR XRE20: DERBY SQL error: SQLCODE: -1, SQLSTATE: XRE20, SQLERRMC: Failover 
performed successfully for database 'replicationdb', the database has been 
shutdown.
ij(CONNECTION1)>

Slave
-----

ij version 10.5
ij> connect 
'jdbc:derby://localhost:1528/replicationdb;startSlave=true;slaveHost=localhost';
ERROR XRE08: DERBY SQL error: SQLCODE: -1, SQLSTATE: XRE08, SQLERRMC: 
Replication slave mode started successfully for database 'replicationdb'. 
Connection refused because the database is in replication slave mode.
ij> connect 'jdbc:derby://localhost:1528/replicationdb';
ij> select * from narayanan;
AGE        |NAME                          
------------------------------------------

0 rows selected

The replication suite of tests also passed fine

[EMAIL PROTECTED]:~/work/workspaces/Derby3489/test2$ java 
junit.textui.TestRunner 
org.apache.derbyTesting.functionTests.tests.replicationTests.ReplicationSuite
........
Time: 629.492

OK (8 tests)

> Error message XRE04 does not include the right port number.
> -----------------------------------------------------------
>
>                 Key: DERBY-3489
>                 URL: https://issues.apache.org/jira/browse/DERBY-3489
>             Project: Derby
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 10.4.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: V.Narayanan
>         Attachments: Derby3489_1.diff, Derby3489_1.stat, Derby3489_2.diff, 
> Derby3489_2.stat, Derby3489_3.diff, Derby3489_3.stat
>
>
> If the master is not able to connect to the slave, the error messages does 
> not include the right port number:
> ij> connect 
> 'jdbc:derby:masterDB;user=oystein;password=pass;startMaster=true;slaveHost=localhost;slavePort=9901';
> ERROR XRE04: Could not establish a connection to the peer of the replicated 
> database 'masterDB' on address 'localhost:-1'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to