[ 
https://issues.apache.org/jira/browse/DERBY-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rick Hillegas updated DERBY-3703:
---------------------------------

    Attachment: derby-3703-01-ac-jsr169stubsNoJar.diff

Attaching derby-3703-01-ac-jsr169stubsNoJar.diff. This is identical to the 
previous patch except that we do not bother building a sealed jar for the 
stubs. Instead, we point jsr169compile.classpath into the compiled class tree.

My previous comment said that you get identical results if the build sets

jsr169compile.classpath=${out.jsr169.dir}:${java14compile.classpath}

and 

jsr169compile.classpath=${java14compile.classpath}

This is not true. In the first case, the build succeeds. In the second case, 
the build chokes because our jsr169 client does not implement the full JDBC3 
api. So the stubs are providing substantial value.

I believe this is the behavior which developers will see with this patch:

1) Regardless of whether you set jsr169compile.classpath in your 
ant.properties, the Derby build will compile our jsr169 client.

2) If you edit our jsr169 client, adding references to classes which do not 
appear in the jsr169 api, then

  a) you will see compiler errors if you have set jsr169compile.classpath in 
your ant.properties

  b) otherwise, the build will succeed and you will find out about your errors 
only after someone else tries to build in an environment which does set 
jsr169compile.classpath.

I believe that (1) is a step forward over the situation today. I believe that 
(2) is pretty much the situation we are in today.

I am inclined to think that this is good, incremental improvement.

Touches the following files:

A      java/stubs
A      java/stubs/jsr169
A      java/stubs/jsr169/java
A      java/stubs/jsr169/java/sql
A      java/stubs/jsr169/java/sql/Connection.java
A      java/stubs/jsr169/java/sql/Timestamp.java
A      java/stubs/jsr169/java/sql/BatchUpdateException.java
A      java/stubs/jsr169/java/sql/Types.java
A      java/stubs/jsr169/java/sql/Statement.java
A      java/stubs/jsr169/java/sql/DatabaseMetaData.java
A      java/stubs/jsr169/java/sql/Savepoint.java
A      java/stubs/jsr169/java/sql/Date.java
A      java/stubs/jsr169/java/sql/Blob.java
A      java/stubs/jsr169/java/sql/SQLException.java
A      java/stubs/jsr169/java/sql/Clob.java
A      java/stubs/jsr169/java/sql/DataTruncation.java
A      java/stubs/jsr169/java/sql/CallableStatement.java
A      java/stubs/jsr169/java/sql/SQLWarning.java
A      java/stubs/jsr169/java/sql/PreparedStatement.java
A      java/stubs/jsr169/java/sql/ResultSet.java
A      java/stubs/jsr169/java/sql/ResultSetMetaData.java
A      java/stubs/jsr169/java/sql/Time.java
A      java/stubs/jsr169/javax
A      java/stubs/jsr169/javax/sql
A      java/stubs/jsr169/javax/sql/RowSetInternal.java
A      java/stubs/jsr169/javax/sql/RowSetWriter.java
A      java/stubs/jsr169/javax/sql/RowSet.java
A      java/stubs/jsr169/javax/sql/RowSetMetaData.java
A      java/stubs/jsr169/javax/sql/RowSetEvent.java
A      java/stubs/jsr169/javax/sql/RowSetReader.java
A      java/stubs/jsr169/javax/sql/RowSetListener.java
A      java/stubs/jsr169/javax/sql/DataSource.java
M      build.xml
M      tools/ant/properties/dirs.properties

> Make it possible to build the JSR169 support with the jdk1.4 libraries
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3703
>                 URL: https://issues.apache.org/jira/browse/DERBY-3703
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>            Reporter: Rick Hillegas
>         Attachments: derby-3703-01-aa-moveJdbc3methods.diff, 
> derby-3703-01-aa-moveJdbc3methods.diff, derby-3703-01-ab-jsr169stubs.diff, 
> derby-3703-01-ac-jsr169stubsNoJar.diff
>
>
> It would be good to simplify the Derby build so that the whole product could 
> be built out-of-the-box just from what's checked into the Derby repository. 
> As a step toward this goal, it would be good to be able to build the jsr169 
> support without having to download proprietary libraries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to