[ 
https://issues.apache.org/jira/browse/DERBY-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614863#action_12614863
 ] 

Kathey Marsden commented on DERBY-3618:
---------------------------------------

Thanks Erlend for the new patch. I think we are getting very close. Per earlier 
comment  need to ...
- Fix it so ASSERT message prints even if you don't have permission to dump 
threads.
- add permissions to derby_tests.policy to derby.jar and derbyclient.jar to 
have permissions to dump threads.

I tried adding the permissions and with the  permissions it worked fine with my 
assertion and printed the message properly.   It is too bad that our exception 
stack trace has to print after the thread dump, but I guess there is no way 
around it now that the thread dump is part of the message?

On the tests, I don't see actually where setIO permissions are needed.  Is this 
perhaps residual from when the thread dump printed to System.out?

You should be able to give the getStackTrace and modifyThreadGroup permissions 
to derby.jar and derbyclient.jar and avoid having to grant  permissions to all. 
 If you have to grant permissions to all there is some sort of problem with a 
privileged block missing somwhere or something like that.  Take a look at 
derby_tests.policy for default derby.jar, derbyclient.jar permissions.


Thanks again Erlend for all the great work. This is indeed tricky stuff.



> Perform thread dump with ASSERTS with jdk 1.5 or higher
> -------------------------------------------------------
>
>                 Key: DERBY-3618
>                 URL: https://issues.apache.org/jira/browse/DERBY-3618
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Erlend Birkenes
>            Priority: Minor
>         Attachments: DERBY-3618_1.diff, DERBY-3618_2.diff, DERBY-3618_3.diff, 
> DERBY-3618_4.diff, DERBY-3618_5.diff
>
>
> It would be good to have a stack traces for all threads dump to the derby.log 
> when an assertion occurs with JVM's that support it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to