[
https://issues.apache.org/jira/browse/DERBY-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615765#action_12615765
]
Kathey Marsden commented on DERBY-3618:
---------------------------------------
Sorry Knut I committed before you got your comments in. Please let me know if
you think I should back out the change. I have one comment on your comments.
You said:
> - The description of the issue says that the thread dump should be printed
> to >derby.log, but this patch seems to put the thread dump in the output from
> >printStackTrace(), which goes much broader. Doesn't this make the stack
> traces harder >to read, and debugging problems where we don't care about the
> thread dumps harder? >Perhaps it's better to intercept AssertFailure (or
> perhaps any error?) in >BaseTestCase.runBare() and write the thread dump to a
> log file?
We sometimes ask users to try to reproduce failures with sane builds in their
environments and could use the thread dumps in those instances. Having the
thread dump code in the junit test harness won't help in these cases, nor will
it help if the assertion happens in derbyall. I think the change won't make
assertions harder to read, since the stack trace will be right at the top and
the thread dump can be ignored if so desired.
> Perform thread dump with ASSERTS with jdk 1.5 or higher
> -------------------------------------------------------
>
> Key: DERBY-3618
> URL: https://issues.apache.org/jira/browse/DERBY-3618
> Project: Derby
> Issue Type: Improvement
> Components: Services
> Affects Versions: 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Erlend Birkenes
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: DERBY-3618_1.diff, DERBY-3618_2.diff, DERBY-3618_3.diff,
> DERBY-3618_4.diff, DERBY-3618_5.diff, DERBY-3618_6.diff, DERBY-3618_7.diff
>
>
> It would be good to have a stack traces for all threads dump to the derby.log
> when an assertion occurs with JVM's that support it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
