[ 
https://issues.apache.org/jira/browse/DERBY-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636013#action_12636013
 ] 

Knut Anders Hatlen commented on DERBY-3874:
-------------------------------------------

I think the patch looks good. +1 to commit. (rrefjdbc88908.html and 
rrefsqlj55788.html in the zip file didn't mention atan2, but they looked OK 
when I built the docs myself.)

To answer some of your questions:

> (However, there seem to be no implementations of POWER, ROUND, or TRUNCATE, 
> for whatever reason.)

Before DERBY-3063, we had none of the 2-arg functions. ATAN2 was added in that 
issue, and I thought the plan was to add the others as well, but the issue 
appears to have been marked as resolved. It should be easy to add the other 
functions now that we have the mechanism in place, so if there isn't an issue 
for it yet, we should file one.

> I'm guessing we should put the four supported ones (cot, radians, rand, sign) 
> into the JDBC escape syntax topic -- does that make sense?

Yes, that makes sense.

> Derby's support for the other functions in this appendix (string, time and 
> date, system, conversion) is much spottier, apparently. (...)
> Would it be legitimate to add these to the "JDBC escape syntax for fn 
> keyword" topic?

I can't see why it shouldn't be legitimate. And as you said, we already 
document some of the string and time functions there.

> Document numeric function ATAN2(float1,float2)
> ----------------------------------------------
>
>                 Key: DERBY-3874
>                 URL: https://issues.apache.org/jira/browse/DERBY-3874
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kim Haase
>         Attachments: DERBY-3874.diff, DERBY-3874.stat, DERBY-3874.zip
>
>
> Document the numeric function ATAN2(float1,float2).
> Mentioned in the JDBC specification, appendix C.1.
> Implementation documented by the JavaDoc for StrictMath.atan2.
> According to the JDBC specification, table B-1, a JDBC float maps to a Java 
> double.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to