[ 
https://issues.apache.org/jira/browse/DERBY-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658634#action_12658634
 ] 

Myrna van Lunteren commented on DERBY-3984:
-------------------------------------------

Thanks Rick, the patch applied cleanly now. I'll try some builds and run some 
tests...

I did start with a verification pass (compare my svn diff result with your 
patch) and it appears the java files in <trunk>/java/stubs/jsr169/*/* do not 
have svn:eol-style native set, which causes my svn diff to look quite different 
for RowSet.java.
When you get ready to commit, perhaps you can switch on the native property. Or 
we could do it for all stubs/jsr169 files some other time.

> Separate out the small number of build targets which really require JDK1.4 
> features from the bulk of the targets which ought to compile cleanly against 
> small device libraries
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3984
>                 URL: https://issues.apache.org/jira/browse/DERBY-3984
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.5.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-3984-01-aa-defaultToJsr169.diff, 
> derby-3984-01-ab-defaultToJsr169.diff
>
>
> It would be good to make jsr169 the default platform for most Derby build 
> targets. This will allow the build to raise compile-time errors when a 
> checkin violates the small-device contract. Only a small number of features 
> (listed in DERBY-3966) really require JDK1.4. Something like the following 
> may work:
> 1) Finish up DERBY-3966 so that java4compile.classpath defaults to an 
> approximation of ${jdk14xmlSupport}: ${java15compile.classpath}
> 2) Make compile.classpath default to jsr169compile.classpath
> 3) Fortunately, jsr169compile.classpath itself already defaults to 
> ${jsr169stubs}:${java14compile.classpath}
> 4) Change a (hopefully) small number of targets to use 
> java14compile.classpath rather than compile.classpath

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to