[
https://issues.apache.org/jira/browse/DERBY-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658680#action_12658680
]
Myrna van Lunteren commented on DERBY-3984:
-------------------------------------------
Actually, looks like the props are in place for the jdbc3 and jdbc4 stubs. But
yeah, we should deal with that separately.
I did some experiments, and added a silly method to the Driver169 class:
public void bla() {
java.sql.Driver dr = null;
}
As expected based on the (description of the) patch, the build with this passed
when $HOME/ant.properties did not have jsr169compile.classpath set and failed
when it *was* set.
testAttributeAccumulatedConnectionCount has failed like that for you before,
and I think it's probably DERBY-3689.
I've not run any specific tests.
Based on this, I say +1 on the change.
Maybe we should have require committers to build with jsr169? Or is that too
big a requirement? Or at least add a comment to the wiki (I think there is an
area for committers somewhere).
> Separate out the small number of build targets which really require JDK1.4
> features from the bulk of the targets which ought to compile cleanly against
> small device libraries
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3984
> URL: https://issues.apache.org/jira/browse/DERBY-3984
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-3984-01-aa-defaultToJsr169.diff,
> derby-3984-01-ab-defaultToJsr169.diff
>
>
> It would be good to make jsr169 the default platform for most Derby build
> targets. This will allow the build to raise compile-time errors when a
> checkin violates the small-device contract. Only a small number of features
> (listed in DERBY-3966) really require JDK1.4. Something like the following
> may work:
> 1) Finish up DERBY-3966 so that java4compile.classpath defaults to an
> approximation of ${jdk14xmlSupport}: ${java15compile.classpath}
> 2) Make compile.classpath default to jsr169compile.classpath
> 3) Fortunately, jsr169compile.classpath itself already defaults to
> ${jsr169stubs}:${java14compile.classpath}
> 4) Change a (hopefully) small number of targets to use
> java14compile.classpath rather than compile.classpath
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
