[
https://issues.apache.org/jira/browse/DERBY-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663052#action_12663052
]
Myrna van Lunteren commented on DERBY-4004:
-------------------------------------------
Kathey and I did a patch-code-walk-through on IRC.
We noticed the following nits:
- Improve javadoc for dbname on initializeDatabase
- Add javadoc for Database.setDatabaseName
- fix whitespace before call to initializeDefaultStatement.
- in in excsat_secchk_nordbonaccsec.inc, remove comment //writeScalarString
RDBNAM "wombat;create=true
All looks good otherwise.
> Remove required RDBNAM from ACCSEC. Use SECCHK RDBNAM if none is provided on
> ACCSEC
> ------------------------------------------------------------------------------------
>
> Key: DERBY-4004
> URL: https://issues.apache.org/jira/browse/DERBY-4004
> Project: Derby
> Issue Type: Sub-task
> Components: Network Client, Network Server
> Affects Versions: 10.5.0.0
> Reporter: Kathey Marsden
> Assignee: Kathey Marsden
> Priority: Minor
> Attachments: derby-4004-fix_new_protcoltest.diff, derby-4004_diff.txt
>
>
> Currently Derby requires RDBNAM on ACCSEC. The DDM spec lists it as optional.
> For DERBY-728, in order to negotiate the encoding, EXCSAT and ACCSEC will
> need to remain EBCDIC, so we want the RDBNAM to be optional. We can use the
> RDBNAM sent in SECCHK instead.
> Once this is done. Client can be changed to only send RDBNAM on ACCSEC if an
> EBCDIC conversion is possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
