[
https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711613#action_12711613
]
Kathey Marsden commented on DERBY-4217:
---------------------------------------
Regarding keeping alternative port, being port +1, I guess that's ok. Folks
would just have to be aware that they need to skip a port when running
concurrent tests.
I am not sure I like putting port in BaseTestCase, initializing it there and
passing it around from all the tests, when the same work can be done in
TestConfiguration. For non-replication tests and decorators, I think that
they can all use the no-arg constructor and the port can be initialized there
to either the default or the system property setting and the tests and
decorators don't need to pass in port at all. If you agree, I think you can go
ahead and make those changes.
Replication I need to understand better. I unfortunately don't have any
experience with this feature or the tests. ReplicationRun.java has these ports
static int masterServerPort = 1527; // .. default..
static String slaveServerHost = "localhost";
static int slaveServerPort = 3527; // .. ..
static String testClientHost = "localhost";
static int slaveReplPort = 6666;
I seem to recall another one that was four thousand something, that I can't
seem to find right away. I need to study what all these ports are used for
(and how replication works).
My gut feeling is that ultimately we will be able to remove the
TestConfiguration constructor that takes a port argument and process the
replication specific ports setting in the replication tests. Alternately
there could be fields for all the additional replication ports needed in
TestConfiguration again processed in the no-arg constructor.
I will look at the replication piece some more and would sure appreciate advice
from someone familiar with replication and the tests. Meanwhile for the other
tests, I think our goal should be that non of them use the TestConfiguration
constructor that takes a port parameter, but rather use the no-arg constructor
and initialize port there.
> Make the default port for the suites.All run configurable with a system
> property.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4217
> URL: https://issues.apache.org/jira/browse/DERBY-4217
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.6.0.0
> Reporter: Tiago R. Espinha
> Assignee: Tiago R. Espinha
> Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
> DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat,
> ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a
> system property passed on to the JVM.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
