[
https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724513#action_12724513
]
Kathey Marsden commented on DERBY-3834:
---------------------------------------
Thanks Tiago for reviving this test. I ran the test with IBM 1.6 and it passed
and confirmed that it is skipped with weme.
You should remove references to the old test in functionTests/suites/
DerbyNetClientRemote.exclude
DerbyNetClientUseprocess.exclude
DerbyNetRemote.exclude
DerbyNetUseprocess.exclude
derbynetmats.runall
j9derbynetmats.runall
and run derbyall to make sure all references to the old test are removed.
In the test I think it would be good to comment that a separate database was
necessary to ensure consistent output above the call to
singleUseDatabaseDecorator.
I think x_testRuntimeInfo and x_testRuntimeInfoMethod and related constants
could be more descriptively named, like x_testRuntimeInfoWithActiveConn and
x_testRuntimeInfoAfterConnClose.
I am a bit confused by x_testRuntimeInfoLocale, even in the original test. I
would have expected it to test non-English output, but instead runs with:
"-Duser.language=err", "-Duser.country=DE",
which makes it revert to English I guess. I think it would be better if it
tested the localization with user.language=de and then just check the output
for some German string.
> Convert derbynet/runtimeinfo to JUnit
> -------------------------------------
>
> Key: DERBY-3834
> URL: https://issues.apache.org/jira/browse/DERBY-3834
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.5.1.1
> Reporter: Erlend Birkenes
> Assignee: Tiago R. Espinha
> Priority: Minor
> Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat,
> Derby-3834_1.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
