[ 
https://issues.apache.org/jira/browse/DERBY-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746103#action_12746103
 ] 

Dag H. Wanvik commented on DERBY-4272:
--------------------------------------

The resulting script (dag-sample-1.sql) has some issues:

-The role creation can not occur before the DBO has made a connection.
- SET ROLE "NONE" is not valid, it should be SET ROLE NONE (without the text 
quotes). It is an identifier, not a string.
- The commented out statements lacked a final semicolon - it would be nice to 
add that so the user can just uncomment
  the connect statements.
- The APP schema did not have any objects in it, so it might be skipped. Derby 
auto-creates schemas anyway, 
  so in general there is no  need to create empty schemas. With authentication, 
in my case there was no defined
  user called "APP", so   I had to remove that part of the script to make it 
run.

I am actually thinking now that the uncommenting serves little purpose.. Maybe 
we might as well output those statements also
and let dblook issue a warning on the console that the script does not contain 
passwords?

 

> SQL Authorization Support for dblook
> ------------------------------------
>
>                 Key: DERBY-4272
>                 URL: https://issues.apache.org/jira/browse/DERBY-4272
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>         Environment: Any
>            Reporter: Hiranya Jayathilaka
>            Assignee: Hiranya Jayathilaka
>         Attachments: DERBY-4272-changes-u1.txt, DERBY-4272-changes-u2.txt, 
> DERBY-4272-changes-u3.txt, DERBY-4272-changes-u4.txt, DERBY-4272-u1.patch, 
> DERBY-4272-u2.patch, DERBY-4272-u3.patch, DERBY-4272-u4.patch, new.sql, 
> old.sql
>
>
> Currently dblook suffers from two major shortcomings.
> 1. dblook doesn't take the object dependencies into consideration when 
> generating DDL scripts
> 2. dblook doesn't have any support for SQL authorization
> I intend to fix these two issues and improve dblook so that the DDL scripts 
> generated by dblook can be executed without errors under all conditions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to