[
https://issues.apache.org/jira/browse/DERBY-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746148#action_12746148
]
Hiranya Jayathilaka commented on DERBY-4272:
--------------------------------------------
The resulting script (dag-sample-1.sql) has some issues:
- The role creation can not occur before the DBO has made a connection.
Hiranya: OK. I think I can use the arguments that we pass into dblook to
generate a CONNECT statement for DBO
- SET ROLE "NONE" is not valid, it should be SET ROLE NONE (without
the text quotes). It is an identifier, not a string.
Hiranya: This requires a trivial fix. Will carry out immediately.
- The commented out statements lacked a final semicolon - it would be
nice to add that so the user can just uncomment the connect
statements.
Hiranya: Sure thing. Let's add it.
- The APP schema did not have any objects in it, so it might be
skipped. Derby auto-creates schemas anyway, so in general there is
no need to create empty schemas. With authentication, in my case
there was no defined user called "APP", so I had to remove that part
of the script to make it run.
Hiranya: OK. So then guess I'll prevent the APP schema from being generated.
I am actually thinking now that the uncommenting serves little
purpose.. Maybe we might as well output those statements also and let
dblook issue a warning on the console that the script does not contain
passwords?
Hiranya: I think it is required to maintain some backward compatibility? (as
discussed on the mailing list). It was mentioned that without the CONNECT
statements commented out, we cannot directly send the output of dblook to ij
using pipes.
Hiranya: All in all, thanks a lot for the great feedback Dag. I'll make the
suggested changes and send in another patch over the weekend.
> SQL Authorization Support for dblook
> ------------------------------------
>
> Key: DERBY-4272
> URL: https://issues.apache.org/jira/browse/DERBY-4272
> Project: Derby
> Issue Type: Improvement
> Components: Tools
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Assignee: Hiranya Jayathilaka
> Attachments: DERBY-4272-changes-u1.txt, DERBY-4272-changes-u2.txt,
> DERBY-4272-changes-u3.txt, DERBY-4272-changes-u4.txt, DERBY-4272-u1.patch,
> DERBY-4272-u2.patch, DERBY-4272-u3.patch, DERBY-4272-u4.patch,
> dhw-sample-1.sql, new.sql, old.sql
>
>
> Currently dblook suffers from two major shortcomings.
> 1. dblook doesn't take the object dependencies into consideration when
> generating DDL scripts
> 2. dblook doesn't have any support for SQL authorization
> I intend to fix these two issues and improve dblook so that the DDL scripts
> generated by dblook can be executed without errors under all conditions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
