[jira] Commented: (DERBY-4869) Implement JDBC 4.1, the api increment introduced by Java 7

[Knut Anders Hatlen (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976970#action_12976970
 ] 

Knut Anders Hatlen commented on DERBY-4869:
-------------------------------------------

All the new getObject() methods are annotated with 
@SuppressWarnings("unchecked"), presumably because they contain unchecked casts 
like this:

            if ( String.class.equals( type ) ) { return (T) getString( 
parameterIndex ); }

I'm wondering if it might be worthwhile to restructure the methods slightly and 
make the casts checked, so that we don't need to suppress warnings. Something 
like this would silence the warnings, I think:

Object ret;

if (String.class.equals(type)) {
    ret = getString(parameterIndex);
} else if (Integer.class.equals(type)) {
    ret = getInt(parameterIndex);
} else if (....) {
    ....
} else {
    ret = getObject(parameterIndex);
}

return type.cast(ret);

> Implement JDBC 4.1, the api increment introduced by Java 7
> ----------------------------------------------------------
>
>                 Key: DERBY-4869
>                 URL: https://issues.apache.org/jira/browse/DERBY-4869
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>            Reporter: Rick Hillegas
>         Attachments: derby-4869-01-ac-rs-getObject.diff, 
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, 
> derby-4869-02-ab-cs-ps-addBatch.diff, 
> derby-4869-03-aa-rs-getObject-errorCleanup.diff, 
> derby-4869-04-aa-rs-getObject-simplification.diff, 
> derby-4869-05-aa-rs-getObject-exception.diff, 
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, 
> derby-4869-07-aa-timedisplacement.diff, disable-tests.diff, 
> JDBC_4.1_Changes.html
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the 
> changes to the java.sql and javax.sql packages introduced by Java 7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.