[ 
https://issues.apache.org/jira/browse/DERBY-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987026#action_12987026
 ] 

Knut Anders Hatlen commented on DERBY-4869:
-------------------------------------------

On the client side, the connection has the current schema cached in most cases. 
Would it make sense to let the client version of setSchema() check the cached 
value if it exists and do nothing if the new schema is the same as the old one? 
The use case I'm thinking about is applications that start each chunk of work 
with setting the schema.

And some nits:

- The try-finally-close code in the setSchema() methods could be simplified by 
moving the call to prepareStatement() out of the try block and up to the 
declaration of the ps variable. Then the ps could be closed unconditionally in 
the finally block.

- The new methods are indented with a mix of tabs and blanks.

> Implement JDBC 4.1, the api increment introduced by Java 7
> ----------------------------------------------------------
>
>                 Key: DERBY-4869
>                 URL: https://issues.apache.org/jira/browse/DERBY-4869
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-4869-01-ac-rs-getObject.diff, 
> derby-4869-01-ad-rs-getObject.diff, derby-4869-02-aa-cs-ps-addBatch.diff, 
> derby-4869-02-ab-cs-ps-addBatch.diff, 
> derby-4869-03-aa-rs-getObject-errorCleanup.diff, 
> derby-4869-04-aa-rs-getObject-simplification.diff, 
> derby-4869-05-aa-rs-getObject-exception.diff, 
> derby-4869-06-aa-cs-getObject.diff, derby-4869-06-ab-cs-getObject.diff, 
> derby-4869-07-aa-timedisplacement.diff, derby-4869-08-ac-nullHandling.diff, 
> derby-4869-09-ac-abort.diff, derby-4869-10-aa-abortSecurityTest.diff, 
> derby-4869-11-aa-abortHidePrivates.diff, 
> derby-4869-12-aa-xaAndPooledAborts.diff, 
> derby-4869-13-aa-xaAndPooledAbortsSecurityManager.diff, 
> derby-4869-14-ac-closeOnCompletion.diff, derby-4869-15-aa-autoGenKeys.diff, 
> derby-4869-16-aa-clarifyStatementSpec.diff, 
> derby-4869-17-aa-statementTimeoutException.diff, 
> derby-4869-18-aa-getSetSchema.diff, derby-4869-exp-01-aa-noTryCatch.diff, 
> disable-tests.diff, JDBC_4.1_Changes.html, timezone.diff
>
>
> This is a master issue logged to track our work implementing JDBC 4.1, the 
> changes to the java.sql and javax.sql packages introduced by Java 7.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to