[ 
https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009207#comment-13009207
 ] 

Myrna van Lunteren commented on DERBY-5084:
-------------------------------------------

Hi,

I don't see a .out nor .tmp file attached, did you forget that step (you 
wouldn't be the first, nor, I'm sure, the last) or did it fail?

Though tempting to convert this to a straight junit test, where you have more 
control over the output, the name indicates this is a test intended to test the 
ij commands to manage connections. So converting it to straight junit would 
defeat the purpose of the test - it *has* to activate ij.

Perhaps you can add a 'disconnect all' to the top of the sql script and get 
closer to the current output?

The 'master' file (the expected output, which is saved in 
<trunk>/java/testing/org/apache/derbyTesting/functionTests/master/ijConnName.out)
 can be updated. As long as the result is equivalent, makes sense, doesn't hide 
any bugs, and is always the same (i.e. for all jvms, for embedded and 
client/server if the test runs both ways, for all operating systems).


> convert ijConnName.sql to a ScriptTest junit test
> -------------------------------------------------
>
>                 Key: DERBY-5084
>                 URL: https://issues.apache.org/jira/browse/DERBY-5084
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Priority: Trivial
>              Labels: derby_triage10_8
>         Attachments: DERBY-5084.patch
>
>
> In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted 
> to a junit test, probably using ScriptTest.
> Making a separate issue so that that issue can be closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to